Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3Event's eventTime should always be a new date #290

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

nschirmer
Copy link
Contributor

It should not rely on the object's creation date, especially since that value never exists in S3rver.

@nschirmer
Copy link
Contributor Author

@specialkk I closed the last PR and opened this new one for the eventTime fix.

@kherock
Copy link
Collaborator

kherock commented Aug 2, 2018

Thanks, I can take it from here - I still want to remove that unnecessary getter and add a test case.

@kherock kherock merged commit d5ad784 into jamhall:master Aug 2, 2018
@nschirmer
Copy link
Contributor Author

Thanks @specialkk! Cheers.

@nschirmer
Copy link
Contributor Author

@specialkk which version tag will this show up in? 2.2.5 or will you publish another?

@kherock
Copy link
Collaborator

kherock commented Aug 2, 2018

@leontastic is in charge of publishing to npm, it should be v2.2.6 when it's up.

@nschirmer
Copy link
Contributor Author

Hi @leontastic, any chance you could publish 2.2.6 tag soon? I need to coordinate with the serverless-s3-local package afterwards to get them to reference the new version so that this fix ultimately makes its way to my project.

Thank you!

@leontastic
Copy link
Collaborator

Hi @nschirmer, my sincere apologies for being AWOL from Github recently. I have published v2.2.6. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants