fix(deps): update dependency rxjs to v6 [removed]

[renovate]

This Pull Request updates dependency rxjs from ^5.4.0 to ^6.0.0

Release Notes

v6.1.0

Compare Source

Bug Fixes

• audit: will not crash if duration is synchronous (#​3608) (76b7e27), closes #​2743
• delay: fix memory leak (#​3605) (96f05b0)

Features

• isObservable: a new method for checking to see if an object is an RxJS Observable (edb33e5)

---

v6.0.0

Compare Source

Bug Fixes

• audit: will not crash if duration is synchronous (#​3608) (76b7e27), closes #​2743
• delay: fix memory leak (#​3605) (96f05b0)

Features

• isObservable: a new method for checking to see if an object is an RxJS Observable (edb33e5)

---

---

This PR has been generated by Renovate Bot.

[renovate]

PR has been edited

As this PR has been edited, Renovate will stop updating it in order to not cause any conflicts or other problems. If you wish to abandon your edits and have Renovate recreate this PR then you should rename this PR and then close it.

[kherock]

Do we have any concerns about upgrading to RxJS 6? People using the s3Events subject will have to install rxjs-compat or upgrade their code if they're not already using pipeable operators, so I'd consider including this in a minor release rather than a patch release.

[n1ru4l]

@specialkk I think this would be a breaking change?

[kherock]

I actually just realized that we can actually just include both 5.5.x and 6.x as acceptable ranges. However I'm not sure how if the renovate bot can handle dealing with joined ranged (e.g. ^5.5.0 || ^6.0.0).

Also while we're on topic, is there any reason why we pin devDependencies? The aws-sdk update spam all week gets pretty old.

[n1ru4l]

@specialkk I pin dependencies to prevent unwanted breaking changes/bugs in dependencies. Also it consolidates the dev environment. (https://stackoverflow.com/a/28510546/4202031)

I am not a huge fan of accepting ranges, because it increases the possibility of bugs. If there is a way to run tests against multiple npm package versions I am sold 😇

We can also configure renovate to only update dependencies once a weak..