Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from goroutines storing rows in memory to use a channel with a buffer of 1 to hold single rows so we can dump tables that far exceed your system memory. Now we have a goroutine blocking and then filling a buffer for the dump.
The buffer of 1 is what maintains the speed that this has had with the memory improvements. This way we can read from MySQL and write to the file in parallel and not block either. Making this a typical consumer producer problem for memory. The table rows are dynamically allocated so usage is usually fairly small.