Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the memory usage by leaving values as the arrays they are #1

Merged
merged 4 commits into from
Mar 28, 2019
Merged

Reduce the memory usage by leaving values as the arrays they are #1

merged 4 commits into from
Mar 28, 2019

Conversation

BrandonRoehl
Copy link
Member

@BrandonRoehl BrandonRoehl commented Mar 27, 2019 •
edited
Loading

This reduces the memory because we don't have to malloc the space for combined strings and hold.

Reduces memory usage so now we only require n + x bytes in memory for the largest table instead of 2(n+x) for the largest table.

@BrandonRoehl BrandonRoehl marked this pull request as ready for review March 28, 2019 15:05
@BrandonRoehl BrandonRoehl self-assigned this Mar 28, 2019
@BrandonRoehl BrandonRoehl merged commit f61ba94 into jamf:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brazeaudavid brazeaudavid brazeaudavid approved these changes

Assignees

@BrandonRoehl BrandonRoehl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrandonRoehl @brazeaudavid