-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: OTEL schema incompatibility after upgrade #67
Conversation
After the recent upgrade, the server failed to start because the OTel schema version had changed. This is undesirable behaviour: added a unit test to catch this easily before commit.
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request focus on the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Telemetry
participant Resource
User->>Telemetry: Initialize Telemetry
Telemetry->>Resource: resourceWithServiceName(base, serviceName)
Resource-->>Telemetry: Return Resource
Telemetry->>Telemetry: Configure Logging
Telemetry->>User: Telemetry Ready
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 90.40% 90.40%
=======================================
Files 13 13
Lines 521 521
=======================================
Hits 471 471
Misses 34 34
Partials 16 16 ☔ View full report in Codecov by Sentry. |
After the recent upgrade, the server failed to start because the OTel schema version had changed.
This is undesirable behaviour: added a unit test to catch this easily before commit.
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Documentation