Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Netlify #11

Merged
merged 1 commit into from
Apr 6, 2021
Merged

feat: support Netlify #11

merged 1 commit into from
Apr 6, 2021

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Mar 1, 2021

This adds support for Netlify.

Netlify build logs supports some ANSI sequences using ansi_up which supports OSC hyperlinks.

However, Netlify sets the CI enviroment variable, which makes this library return false.

This PR adds support for Netlify by detecting it with the NETLIFY environment variable.

@jamestalmage
Copy link
Owner

@ehmicky - I'm going to assume you've verified this works with Netlify

@ehmicky
Copy link
Contributor Author

ehmicky commented Apr 6, 2021

Hi @jamestalmage, absolutely!

Every Netlify build is defining this NETLIFY environment variable.
OSC hyperlinks are supported in the Netlify build logs 👍

@jamestalmage jamestalmage merged commit 1246ad6 into jamestalmage:master Apr 6, 2021
@jamestalmage
Copy link
Owner

Perfect. Thank you!

@ehmicky ehmicky deleted the feat/netlify branch April 6, 2021 18:54
@ehmicky
Copy link
Contributor Author

ehmicky commented Apr 6, 2021

🎉

For future reference, this is an example of using hyperlinks in Netlify build logs.

Netlify build logs is using ansi_up to convert ANSI sequences to HTML. It seems like there is a bug with OSC hyperlinks when the text includes a space. I filed an issue in drudru/ansi_up#65

@jamestalmage
Copy link
Owner

Published as 2.2.0

@ehmicky
Copy link
Contributor Author

ehmicky commented Apr 7, 2021

Thanks!

FYI, the bug above got fixed 👍

@ehmicky ehmicky mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants