Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace embassy_usb_driver import with re-export from embassy_usb #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dvdsk
Copy link

@dvdsk dvdsk commented Sep 23, 2024

Most embassy users use the git version by pathing crates-io. Its easy to forget to patch both embassy-usb and embassy-usb-driver. By relying on embassy-usb-driver as re-exported by embassy-usb that can no longer happen.

Most embassy users use the git version by pathing crates-io. Its easy to
forget to patch both embassy-usb and embassy-usb-driver. By relying on
embassy-usb-driver as re-exported by embassy-usb that can no longer
happen.
@jamesmunns
Copy link
Owner

I'm not certain I want to merge this. I think the intent of relying on e-u-driver is to have fewer breaking changes as that crate changes less often than e-u does.

That being said, I wasn't able to make that work for the 0.2 to 0.3 transition, so maybe there isn't much value to that.

@dvdsk
Copy link
Author

dvdsk commented Sep 29, 2024

I am fine with leaving this open for a while (be that months or years) or closing it. Its a small change it does not matter to me who makes it if its made at all 👍. Do whatever is most convenient for you, and thanks for making postcard & postcard-rpc. They are both very nice (love the inclusion of the CobsAccumulator btw that saved me quite some time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants