Changes from comment #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmontemagno
requested changes
Aug 21, 2019
MvvmHelpers/WeakEventManager.cs
Outdated
| namespace MvvmHelpers | ||
| { | ||
| public class WeakEventManager | ||
| internal class WeakEventManager |
There was a problem hiding this comment.
Is there a reason we shouldn't make this public? Seems like it could be useful for library creators.
There was a problem hiding this comment.
I read the comment now... hmmmmmm interesting....
There was a problem hiding this comment.
Yes, actually that makes a lot of sense because I want to use the simplest solution in my apps, and I hope that's the case of a lot of other developers too and it's an extra piece of code that needs to be maintained and needs improvement over time.
There was a problem hiding this comment.
I think I am fine keeping it public :)
There was a problem hiding this comment.
Okay I will change it back to public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #45
Changes: