Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NordVPN as provider #61

Merged
merged 4 commits into from
Feb 9, 2021
Merged

Add NordVPN as provider #61

merged 4 commits into from
Feb 9, 2021

Conversation

jeff-hughes
Copy link
Contributor

Adding NordVPN to the list of providers. Note that this is only supported via OpenVPN. For wireguard, they've built an extra layer on top of it called NordLynx, which is intended to avoid having to store identifiable data on their servers. Unfortunately, they don't currently have any documentation on how to set up wireguard to connect to NordLynx. It's set up in their Linux client, but I don't know enough about wireguard config to be able to dig further to try to find out more details.

@jamesmcm
Copy link
Owner

jamesmcm commented Feb 9, 2021

Thanks, it looks great.

Could you please fix the clippy errors? And I'll merge it.

https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

   --> src/providers/nordvpn/openvpn.rs:155:9
    |
155 | /         match self {
156 | |             Self::OnionTcp => true,
157 | |             Self::OnionUdp => true,
158 | |             _ => false,
159 | |         }
    | |_________^ help: try this: `matches!(self, Self::OnionTcp | Self::OnionUdp)`
    |
    = note: `-D clippy::match-like-matches-macro` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

error: match expression looks like `matches!` macro
   --> src/providers/nordvpn/openvpn.rs:163:9
    |
163 | /         match self {
164 | |             Self::DoubleTcp => true,
165 | |             Self::DoubleUdp => true,
166 | |             _ => false,
167 | |         }
    | |_________^ help: try this: `matches!(self, Self::DoubleTcp | Self::DoubleUdp)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro```

@jeff-hughes
Copy link
Contributor Author

There we go -- this was a reminder that I hadn't updated Rust (and clippy) in a while :)

@jamesmcm jamesmcm merged commit 9bcde1f into jamesmcm:master Feb 9, 2021
@jamesmcm
Copy link
Owner

jamesmcm commented Feb 9, 2021

Thanks! I bumped the version so it can build a new release too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants