Improve NetworkManager, firewalld support #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now check NetworkManager is actually running rather than just for the existence of the configuration file, before trying to apply NetworkManager config changes. - Failure to apply NetworkManager config changes now results in a warning instead of an error. - Added detection of systemd's firewalld to permit the veth device needed for the network namespace (much like with Network Manager previously). - Added "recommends" dependencies to Debian dpkg with cargo-deb
This was referenced Aug 13, 2021
Closed
|
|
|
@cebtenzzre thanks, it's addressed in 570eb02 - hopefully the Github action updates work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
existence of the configuration file, before trying to apply
NetworkManager config changes.
warning instead of an error.
needed for the network namespace (much like with Network Manager
previously).