fix(sheet): adapt scrollable.dart to upstream SemanticsNode changes #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR flutter/flutter#137304 makes SemanticsNode.isMergedIntoParent readonly, which makes the customized scrollable.dart incompatible.
richardshiue
changed the title
|
Use this PR before merge: dependency_overrides:
sheet:
git:
url: https://github.com/jamesblasco/modal_bottom_sheet.git
ref: 8ee20bd36acaeb36996a09ba9d0f9e7059bb49df
path: sheet |
Closed
|
I deprecated this lib |
|
@OpenJarvisAI Any alternatives? |
|
Don't using it. |
|
@jamesblasco Hi, Can u still clarify sheet and modal_sheet which one to use? Users are really lack of maintainance back for fast evoling flutter versions. We can just focus on one single lib to maintain. |
|
Model bottom sheet should be the one to prioritized. It is the one used the most and definitely the one that should be updated more often. Sheet has more features and it is the one I personally use in my projects so I will be also maintaining it. But I think long term modal bottom sheet will be the one that persists even if it adopts some ideas from the sheet package |
TasnimAnas
pushed a commit
to TasnimAnas/modal_bottom_sheet
that referenced
this pull request
Jul 13, 2024
…asco#387) This PR flutter/flutter#137304 makes SemanticsNode.isMergedIntoParent readonly, which makes the customized scrollable.dart incompatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR flutter/flutter#137304 makes SemanticsNode.isMergedIntoParent readonly, which makes the customized scrollable.dart incompatible when using flutter version 3.18 and upwards