Include file path in the error message #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the error clear directly on the build log output page. Before the change, the file name was visible only on the build summary (annotations).
Comment on lines
+15
to
+16
| if [ -z "$path" ]; then | ||
| # Skip objects which are not files (commits, trees) |
There was a problem hiding this comment.
There should be no assumption that the commit is the one currently checked out.
Nor is there any reason to limit it to not-commits.
e.g. someone might be really silly and create a multi-megabyte commit message.
| @@ -25,7 +29,7 @@ while read -r obj_id path; do | |||
|
|
|||
| if [ "$GITHUB_ACTION" != "" ] && [ "$GITHUB_WORKFLOW" != "" ]; then | |||
| # Output special github workflow metadata | |||
| printf "::error file=%s::Large git object (%d bytes)\n" "$path" "$size" | |||
| echo "::error file=$path::File $path is too large ($size bytes, $max_size is the limit)" | |||
There was a problem hiding this comment.
Why swap from printf to echo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the error clear directly on the build log output page. Before
the change, the file name was visible only on the build summary
(annotations).