Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 130] Update the unix parse function to be specific to either seconds of milliseconds #135

Merged
merged 2 commits into from
Dec 18, 2021

Conversation

jama5262
Copy link
Owner

@jama5262 jama5262 commented Dec 18, 2021

What does this PR do?

Resolved #130

Create two new functions and update the unix parse function to be specific to either seconds of milliseconds

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change)
  • Directed the PR to develop branch and not the master branch
  • Wrote additional tests, if needed
  • All tests have passed
  • I have updated the documentation accordingly, if needed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2021

Codecov Report

Merging #135 (bc5842a) into develop (ea33349) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #135      +/-   ##
===========================================
- Coverage    93.72%   93.72%   -0.01%     
===========================================
  Files           33       33              
  Lines         1323     1322       -1     
===========================================
- Hits          1240     1239       -1     
  Misses          83       83              
Impacted Files Coverage Δ
lib/src/jiffy.dart 91.09% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea33349...bc5842a. Read the comment docs.

@jama5262 jama5262 marked this pull request as ready for review December 18, 2021 10:19
@jama5262 jama5262 merged commit 746c587 into develop Dec 18, 2021
@jama5262 jama5262 deleted the issue-130-fix-jiffy-unix branch December 18, 2021 10:19
@jama5262 jama5262 linked an issue Dec 18, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jiffy.unix throws JiffyException for dates before 2001/9/10
2 participants