Fix locale fa loading based on moment documentation. #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When you use the
moment.loadPersian()
function you will face an error that says thefa
locale is not loaded.Based on this document of
moment
this is a bug that preventsmoment.locale
from being loaded. And recommended solution is using this workaround:I applied this to solve the problem. And this PR also fix the #131.
And we want to change the
fa
locale using themoment.defineLocale
function but we should use themoment.updateLocale()
to change an existing locale.moment.defineLocale()
should only be used for creating a new locale based on this.