Fix composite project setup #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@MattiasBuelens thank you! I think this is pretty much as good as it gets. |
Owner
|
I'll write this up at SO tomorrow and credit you. |
Contributor
Author
|
Sweet! I'm Mattias Buelens on SO, in case you want to @ me. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt! 😛
mainthe "root project", i.e. runtsc -b src/main(instead oftsc -b)rootDirandoutDironce in the top-level sharedtsconfigmainbecause they are not inherited throughextends, seereferencesare not inherited intsconfig.jsonmicrosoft/TypeScript#27098That seems to fix all build-related errors. There are still type errors because of microsoft/TypeScript#14877, but you could work around that with something like
self as DedicatedWorkerGlobalScope.