[#304] Add a release Jenkinsfile #305
Conversation
marko-bekhta
commented
Oct 8, 2025
marko-bekhta
commented
- Fixes Create a Release Jenkins job #304
|
|
||
| // Set up git so that we can create commits | ||
| sh 'git config --local user.name "Jakarta Validation"' | ||
| sh 'git config --local user.email "[email protected]"' |
There was a problem hiding this comment.
{
"id": 383,
"projectId": "ee4j.validation",
"username": "genie.validation",
"github.com": {
"username": "eclipse-validation-bot",
"email": "[email protected]"
}
}There was a problem hiding this comment.
it may 100% be wrong 😃, I took the dev mailing list one from: https://accounts.eclipse.org/mailing-list/bean-validation-dev ...
There was a problem hiding this comment.
But this is email of github user, not mailing list address.
There was a problem hiding this comment.
thanks!
my thinking was it's a git commit, so the real GH user is not required and dev list mail would do... but since you provided a GH user one! let me send a patch fixing it.
There was a problem hiding this comment.
btw ... a related question.. I was thinking that it would be good to upload the javadocs (and in the spec repo the spec html/pdf) as part of the release process, but I didn't see anything related to uploads in the old CI jobs, and randomly looking at some wikis and guides produced 0 results 😕. Maybe you have some pointers ? 🤞🏻 😃
There was a problem hiding this comment.
- Usually and unfortunately I spot such things too late (like Commits created during release are not using proper
user.emailmail-api#773) - once the commits are already published. (As the config is often stored directly in Jenkins job). So happy it's still fixable here 😁
2 participants
