Skip to content

Conversation

gavinking
Copy link
Contributor

See #74.

@gavinking gavinking linked an issue Oct 8, 2025 that may be closed by this pull request
@gavinking gavinking marked this pull request as draft October 8, 2025 12:50
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Noted a couple of minor grammar fixes, but approving in advance.


If any element of a path expression evaluates to a null value, the whole path expression evaluates to a null value.

NOTE: An implementation of the core language is not required to support path expressions which involve multiple entities. For example, if `Book` and `Publisher` are different entity types, then the path expression `book.publisher.name` is not part of the core language.footnote:[Path expressions involving multiple entities are called _implicit joins_ by the Jakarta Persistence specification.]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@otaviojava I'm adding this NOTE to address #86.

Copy link
Contributor

@otaviojava otaviojava Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On non-relational databases, this kind of navigation is usually implicit, since related data is stored within the same aggregate.

The note makes sense overall.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On non-relational databases, this kind of navigation is usually implicit, since related data is stored within the same aggregate.

We would consider that navigation from a root entity to its embeddable, not navigation between entities, I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.
I agreed!

@gavinking gavinking marked this pull request as ready for review October 9, 2025 09:59
@gavinking
Copy link
Contributor Author

Made a couple of improvements and moved this out of draft mode.

@gavinking
Copy link
Contributor Author

You have both approved this, but I'm not clear on whether @njr-11 has seen commit 07630a9. So I'll leave this open for a few more hours until he wakes up.

@njr-11
Copy link
Contributor

njr-11 commented Oct 10, 2025

You have both approved this, but I'm not clear on whether @njr-11 has seen commit 07630a9. So I'll leave this open for a few more hours until he wakes up.

That commit looks fine - thanks for checking!

@gavinking gavinking merged commit 0f625e7 into jakartaee:main Oct 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

review semantics of path expressions

3 participants