Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce @Column(secondPrecision) & clarify semantics of @Column members #568

Merged
merged 3 commits into from
Feb 26, 2024
Merged

introduce @Column(secondPrecision) & clarify semantics of @Column members #568

merged 3 commits into from
Feb 26, 2024

Conversation

gavinking
Copy link
Contributor

see #563

@gavinking gavinking linked an issue Jan 12, 2024 that may be closed by this pull request
precision of SQL time and timestamp types #563
Closed
lukasj
lukasj reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new secondPrecision member needs to be added also to orm_3.2.xsd

@gavinking
Copy link
Contributor Author

the new secondPrecision member needs to be added also to orm_3.2.xsd

Pushed. Did I do it right?

@lukasj
Copy link
Contributor

lukasj commented Feb 14, 2024

the new secondPrecision member needs to be added also to orm_3.2.xsd

Pushed. Did I do it right?

Almost, but you're getting there. MapKeyColumn is there too

@gavinking
Copy link
Contributor Author

I didn't add anything new to MapKeyColumn, just synchronized the javadoc.

And I don't think secondPrecision() would make sense for MapKeyColumn.

@lukasj
Copy link
Contributor

lukasj commented Feb 14, 2024

I didn't add anything new to MapKeyColumn, just synchronized the javadoc.

Ah, right, an oversight on my end, sorry.

@lukasj lukasj merged commit 56dc2be into jakartaee:master Feb 26, 2024
2 checks passed
@rbygrave rbygrave mentioned this pull request Feb 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj approved these changes

Assignees

@lukasj lukasj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

precision of SQL time and timestamp types
2 participants
@gavinking @lukasj