-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature conv3d #53
Merged
Merged
Feature conv3d #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amazing job! This is great work for your first contribution. I'll take a look at debugging later today or tomorrow. Should have it merged by the weekend |
thanks for your comment! I'm still debugging.. |
Now, the dim. mismatch resolved! |
Amazing work, merged! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what does this PR do
test log
test fails at this time of writing(24. 05. 02)I gotindex out of bounds error
when the graphexecute()
calledlen(inp1)==720
, because example input data has 5 channels, 16x9x5=720 volume.op.rs::get_index()
fails wheredata[ind.exec_single_var_stack(index, stack)]
need help (__)
I have no idea where and how to start debug.. I'd really appreciate any ideas you could suggest. @jafioti @TheSeamau5
println!("{:?}", cx)