[jaegermcp] Enable tenancy enforcement

[whiplashvin]

Which problem is this PR solving?

Secure MCP endpoint with query tenancy enforcement
#8173

Description of the changes

• Wrap MCP HTTP handler with tenancy.ExtractTenantHTTPHandler
• Get TenancyManager from jaegerquery extension
• Extend jaegerquery.Extension interface with TenancyManager() method
• Wire tenancy manager in jaegerquery server
• Update extension tests with tenancy manager mocks

How was this change tested?

• make fmt
• make lint
• make test

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/main/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully: make lint test

AI Usage in this PR (choose one)

See AI Usage Policy.

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[Copilot]

Pull request overview

This pull request secures the MCP endpoint by adding tenancy enforcement, preventing unauthorized access to MCP tools in multi-tenant Jaeger deployments. The PR extends the jaegerquery extension to expose a tenancy manager, which is then used to wrap the MCP HTTP handler with tenant validation when tenancy is enabled.

Changes:

• Extended the jaegerquery.Extension interface with a TenancyManager() method to expose the tenancy manager
• Added tenancy manager storage and retrieval in the jaegerquery server
• Obtained the tenancy manager from the jaegerquery extension in the MCP server's Start method
• Wrapped the MCP HTTP handler with tenancy.ExtractTenantHTTPHandler when tenancy is enabled
• Updated all test mocks and fixtures to support the new tenancy manager field
• Added a regression test that verifies the MCP endpoint returns 401 Unauthorized when tenancy is enabled and no tenant header is provided

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
cmd/jaeger/internal/extension/jaegerquery/server.go	Added tenancyManager field to server struct, stored the tenancy manager in Start(), and implemented TenancyManager() method
cmd/jaeger/internal/extension/jaegerquery/extension.go	Extended Extension interface with TenancyManager() method and added tenancy import
cmd/jaeger/internal/extension/jaegerquery/extension_test.go	Updated mock to implement TenancyManager() and added test verification
cmd/jaeger/internal/extension/jaegermcp/server.go	Added tenancy import, obtained tenancy manager from query extension, and wrapped MCP handler with tenancy enforcement
cmd/jaeger/internal/extension/jaegermcp/server_test.go	Updated mock extension and added helper function for creating host with tenancy, plus regression test

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[yurishkuro]

minor nits, lgtm

[Copilot]

Pull request overview

This PR secures the Jaeger MCP /mcp HTTP endpoint by enforcing the same tenancy header extraction/validation used by Jaeger Query, preventing cross-tenant or unauthenticated metadata enumeration in multi-tenant deployments.

Changes:

• Exposes the Query extension’s tenancy manager via a new TenancyManager() method on jaegerquery.Extension.
• Wraps the MCP HTTP handler with tenancy.ExtractTenantHTTPHandler(...) using the query extension’s tenancy manager.
• Updates tests/mocks and adds a regression test asserting /mcp returns 401 Unauthorized when tenancy is enabled and the tenant header is missing.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
cmd/jaeger/internal/extension/jaegerquery/server.go	Stores and exposes the query server’s tenancy manager via TenancyManager()
cmd/jaeger/internal/extension/jaegerquery/extension.go	Extends the jaegerquery.Extension interface to include TenancyManager()
cmd/jaeger/internal/extension/jaegerquery/extension_test.go	Updates extension retrieval tests to include tenancy manager in the mock
cmd/jaeger/internal/extension/jaegermcp/server.go	Wraps MCP HTTP handler with tenancy extraction/enforcement
cmd/jaeger/internal/extension/jaegermcp/server_test.go	Updates mocks and adds a tenancy-enforcement regression test for /mcp

Comments suppressed due to low confidence (1)

cmd/jaeger/internal/extension/jaegerquery/server.go:126

• TenancyManager() can currently return nil if it's called before Start() (since tenancyManager is only set inside Start). Because other extensions now call this during their own startup (e.g., MCP wraps its handler with ExtractTenantHTTPHandler which panics on nil), it would be safer for TenancyManager() to guarantee a non-nil return (e.g., lazy-init from s.config.Tenancy, or initialize the manager in newServer and reuse it in Start).

	tm := tenancy.NewManager(&s.config.Tenancy)
	s.tenancyManager = tm

	caps := querysvc.StorageCapabilities{
		ArchiveStorage: opts.ArchiveTraceReader != nil && opts.ArchiveTraceWriter != nil,
		MetricsStorage: s.config.Storage.Metrics != "",
	}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.65%. Comparing base (cae595f) to head (17ccadc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8203      +/-   ##
==========================================
+ Coverage   95.63%   95.65%   +0.02%     
==========================================
  Files         318      318              
  Lines       16780    16785       +5     
==========================================
+ Hits        16047    16056       +9     
+ Misses        578      575       -3     
+ Partials      155      154       -1     

Flag	Coverage Δ
badger_direct	9.05% <ø> (ø)
badger_e2e	1.04% <ø> (ø)
cassandra-4.x-direct-manual	13.25% <ø> (ø)
cassandra-4.x-e2e-auto	1.03% <ø> (ø)
cassandra-4.x-e2e-manual	1.03% <ø> (ø)
cassandra-5.x-direct-manual	13.25% <ø> (ø)
cassandra-5.x-e2e-auto	1.03% <ø> (ø)
cassandra-5.x-e2e-manual	1.03% <ø> (ø)
clickhouse	1.16% <ø> (ø)
elasticsearch-6.x-direct	16.83% <ø> (ø)
elasticsearch-7.x-direct	16.86% <ø> (ø)
elasticsearch-8.x-direct	17.01% <ø> (ø)
elasticsearch-8.x-e2e	1.04% <ø> (ø)
elasticsearch-9.x-e2e	1.04% <ø> (ø)
grpc_direct	7.79% <ø> (ø)
grpc_e2e	1.04% <ø> (ø)
kafka-3.x-v2	1.04% <ø> (ø)
memory_v2	1.04% <ø> (ø)
opensearch-1.x-direct	16.91% <ø> (ø)
opensearch-2.x-direct	16.91% <ø> (ø)
opensearch-2.x-e2e	1.04% <ø> (ø)
opensearch-3.x-e2e	1.04% <ø> (ø)
query	1.04% <ø> (ø)
tailsampling-processor	0.52% <ø> (ø)
unittests	94.34% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.