Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile build_ui target to lerna structure #798

Merged
merged 5 commits into from
Jul 18, 2018

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented May 2, 2018

Blocked on jaegertracing/jaeger-ui#209.

Blocked on verifying the latest UI. The UI is good to go.

Update the build_ui Makefile target to handle the post-Lerna Jaeger UI folder structure.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d9b14c6 on tiffon:jaeger-ui-lerna into c7891a4 on jaegertracing:master.

@tiffon tiffon requested a review from jpkrohling as a code owner June 30, 2018 22:52
@tiffon tiffon changed the title [BLOCKED] Update Makefile build_ui target to lerna structure Update Makefile build_ui target to lerna structure Jun 30, 2018
@jpkrohling
Copy link
Contributor

The build for ALL_IN_ONE=true seems to have failed due to:

rm -rf jaeger-ui-build && mkdir jaeger-ui-build
cp -r jaeger-ui/packages/jaeger-ui/build jaeger-ui-build/
cp: cannot stat ‘jaeger-ui/packages/jaeger-ui/build’: No such file or directory
make: *** [build_ui] Error 1

@tiffon
Copy link
Member Author

tiffon commented Jul 2, 2018

@jpkrohling Thanks, will update the commit associated with the jaeger-ui repo.

@codecov
Copy link

codecov bot commented Jul 16, 2018

Codecov Report

Merging #798 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #798   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         126    126           
  Lines        6080   6080           
=====================================
  Hits         6080   6080

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7919cd9...48c0ac1. Read the comment docs.

@tiffon tiffon changed the title Update Makefile build_ui target to lerna structure [Blocked] Update Makefile build_ui target to lerna structure Jul 16, 2018
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but since this is also pulling the latest UI, can you include the (future) changes in the CHANGELOG in this repo?

@tiffon
Copy link
Member Author

tiffon commented Jul 17, 2018 via email

@tiffon tiffon changed the title [Blocked] Update Makefile build_ui target to lerna structure Update Makefile build_ui target to lerna structure Jul 18, 2018
@yurishkuro yurishkuro merged commit 0a40309 into jaegertracing:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants