-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Makefile build_ui target to lerna structure #798
Conversation
Signed-off-by: Joe Farro <[email protected]>
The build for
|
@jpkrohling Thanks, will update the commit associated with the jaeger-ui repo. |
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #798 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 126 126
Lines 6080 6080
=====================================
Hits 6080 6080 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but since this is also pulling the latest UI, can you include the (future) changes in the CHANGELOG in this repo?
Will do. Also, we are in the process of verifying there wasn't a regression
in the latest UI. I'll removed the [Blocked] once that is sorted out.
… |
Signed-off-by: Joe Farro <[email protected]>
Blocked on jaegertracing/jaeger-ui#209.Blocked on verifying the latest UI.The UI is good to go.Update the
build_ui
Makefile target to handle the post-Lerna Jaeger UI folder structure.