[Feature]: Upgrade to OTEL Collector 1.37 #7400
Merged
yurishkuro merged 3 commits intoJul 30, 2025
Merged
Conversation
Signed-off-by: Harshil Gupta <harshilgupta1808@gmail.com>
Signed-off-by: Harshil Gupta <harshilgupta1808@gmail.com>
wololowarrior
force-pushed
the
fix-ci-failing-due-to-configgrpc-version-upgrade
branch
from
c1c8286 to
139d50a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7400 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 375 375
Lines 22951 22951
=======================================
Hits 22135 22135
Misses 617 617
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wololowarrior
force-pushed
the
fix-ci-failing-due-to-configgrpc-version-upgrade
branch
from
5a31590 to
ee43963
Compare
yurishkuro
reviewed
Jul 30, 2025
| { | ||
| "kind": 2, | ||
| "name": "foobar", | ||
| "parentSpanId": "", |
Member
There was a problem hiding this comment.
Unexpected, what is changed upstream to cause this?
Contributor
Author
There was a problem hiding this comment.
Yeah, it made me curious as well. Though I'm not versed with opentelemetry-collector repo, using claude I was probably able to identify the root cause. Lemme know if it makes sense:
- This adds a marshal template which omits the field if its equal to the default.
Resovles to:
if ms.orig.ParentSpanId != data.SpanID([8]byte{}) {
dest.WriteObjectField("parentSpanId")
ms.orig.ParentSpanId.MarshalJSONStream(dest)
}
ParentSpanIdis not being set in the test thus it gets the default value of SpanID, i.e.data.SpanID([8]byte{})
Member
There was a problem hiding this comment.
cool, thanks for finding the reference (open-telemetry/opentelemetry-collector#13450). It's not a deal-breaker change, but I commented on that PR because they were saying "no changes to marshaling".
Member
|
Please change pr title to be about OTEL upgrade |
wololowarrior
changed the title
yurishkuro
approved these changes
Jul 30, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7398
Description of the changes
REGENERATE_SNAPSHOTS=true make testto update snapshotsHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test