Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional model/ cleanup #6610

Merged
merged 4 commits into from
Jan 25, 2025
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jan 25, 2025

Which problem is this PR solving?

Description of the changes

  • Move OTEL-IDs helpers to v1adapter
  • Clean-up model aliases
  • Remove unnecessary test in model (it exists in idl/model/v1)
  • Prohibit dependencies on github.com/jaegertracing/jaeger/model via linter
  • Fix storage.proto code-gen to not rely on model/

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro requested a review from a team as a code owner January 25, 2025 18:32
@yurishkuro yurishkuro requested a review from jkowall January 25, 2025 18:32
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (d7ab0f8) to head (6a2751a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6610      +/-   ##
==========================================
- Coverage   96.07%   96.05%   -0.02%     
==========================================
  Files         364      364              
  Lines       20747    20750       +3     
==========================================
  Hits        19932    19932              
- Misses        620      622       +2     
- Partials      195      196       +1     
Flag Coverage Δ
badger_v1 9.88% <46.66%> (+0.02%) ⬆️
badger_v2 1.83% <60.00%> (+0.02%) ⬆️
cassandra-4.x-v1-manual 15.02% <46.66%> (+0.02%) ⬆️
cassandra-4.x-v2-auto 1.82% <60.00%> (+0.02%) ⬆️
cassandra-4.x-v2-manual 1.82% <60.00%> (+0.02%) ⬆️
cassandra-5.x-v1-manual 15.02% <46.66%> (+0.02%) ⬆️
cassandra-5.x-v2-auto 1.82% <60.00%> (+0.02%) ⬆️
cassandra-5.x-v2-manual 1.82% <60.00%> (+0.02%) ⬆️
elasticsearch-6.x-v1 19.23% <46.66%> (+0.02%) ⬆️
elasticsearch-7.x-v1 19.31% <46.66%> (+0.02%) ⬆️
elasticsearch-8.x-v1 19.48% <46.66%> (+0.02%) ⬆️
elasticsearch-8.x-v2 1.83% <60.00%> (+0.02%) ⬆️
grpc_v1 11.18% <46.66%> (+0.02%) ⬆️
grpc_v2 8.04% <60.00%> (+0.02%) ⬆️
kafka-3.x-v1 10.17% <46.66%> (+0.02%) ⬆️
kafka-3.x-v2 1.83% <60.00%> (+0.02%) ⬆️
memory_v2 1.83% <60.00%> (+0.02%) ⬆️
opensearch-1.x-v1 19.36% <46.66%> (+0.02%) ⬆️
opensearch-2.x-v1 19.36% <46.66%> (+0.02%) ⬆️
opensearch-2.x-v2 1.83% <60.00%> (-0.09%) ⬇️
tailsampling-processor 0.48% <0.00%> (-0.01%) ⬇️
unittests 94.84% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro enabled auto-merge (squash) January 25, 2025 19:04
@yurishkuro yurishkuro merged commit 7168853 into jaegertracing:main Jan 25, 2025
55 checks passed
@yurishkuro yurishkuro deleted the model-clean-up branch January 25, 2025 19:13
@yurishkuro yurishkuro mentioned this pull request Jan 25, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants