Support sampling file reload interval #6440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6440 +/- ##
==========================================
- Coverage 96.27% 96.25% -0.03%
==========================================
Files 369 369
Lines 21048 21051 +3
==========================================
- Hits 20264 20262 -2
- Misses 600 604 +4
- Partials 184 185 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
commented
Dec 30, 2024
Signed-off-by: Yuri Shkuro <[email protected]>
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 5, 2025
## Which problem is this PR solving? - Accidentally stumbled upon this when looking at jaegertracing#6431 - Turns out v2 config did not support all the options from v1 ## Description of the changes - Add support for reload interval ## How was this change tested? `go run ./cmd/jaeger` ``` $ curl "http://localhost:5778/?service=x" {"strategyType":0,"probabilisticSampling":{"samplingRate":1}}% ``` Edit cmd/jaeger/sampling-strategies.json to change default to 0.1. Observe server logs showing new values. ``` $ curl "http://localhost:5778/?service=x" {"strategyType":0,"probabilisticSampling":{"samplingRate":0.1}}% ``` --------- Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
go run ./cmd/jaegerEdit cmd/jaeger/sampling-strategies.json to change default to 0.1.
Observe server logs showing new values.