Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es-index-cleaner] Use OTEL helper instead of tlscfg #6259

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

chahatsagarmain
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

@yurishkuro yurishkuro merged commit b2e84b4 into jaegertracing:main Nov 26, 2024
51 of 52 checks passed
@chahatsagarmain chahatsagarmain deleted the es-option-tls branch November 26, 2024 14:10
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.43%. Comparing base (4d1c7d8) to head (610e730).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cmd/es-index-cleaner/app/flags.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6259       +/-   ##
===========================================
+ Coverage   48.76%   96.43%   +47.66%     
===========================================
  Files         179      355      +176     
  Lines       10803    20155     +9352     
===========================================
+ Hits         5268    19436    +14168     
+ Misses       5092      530     -4562     
+ Partials      443      189      -254     
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.59% <ø> (ø)
elasticsearch-7.x-v1 18.68% <ø> (ø)
elasticsearch-8.x-v1 18.85% <ø> (ø)
elasticsearch-8.x-v2 1.66% <ø> (ø)
grpc_v1 9.44% <ø> (ø)
grpc_v2 6.98% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.66% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 18.73% <ø> (ø)
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.34% <60.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants