Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Add ES config comments #6110

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

yurishkuro
Copy link
Member

Improve documentation

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro requested a review from a team as a code owner October 22, 2024 17:33
@yurishkuro yurishkuro requested a review from jkowall October 22, 2024 17:33
@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (acbc0e1) to head (07f8bce).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6110   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         352      352           
  Lines       19986    19986           
=======================================
  Hits        19280    19280           
  Misses        522      522           
  Partials      184      184           
Flag Coverage Δ
badger_v1 8.42% <ø> (ø)
badger_v2 1.70% <ø> (ø)
cassandra-4.x-v1 14.57% <ø> (ø)
cassandra-4.x-v2 1.64% <ø> (ø)
cassandra-5.x-v1 14.57% <ø> (ø)
cassandra-5.x-v2 1.64% <ø> (ø)
elasticsearch-6.x-v1 18.73% <ø> (ø)
elasticsearch-7.x-v1 18.81% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 18.97% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.69% <ø> (-0.02%) ⬇️
grpc_v1 8.78% <ø> (+0.01%) ⬆️
grpc_v2 6.72% <ø> (+0.01%) ⬆️
kafka-v1 8.99% <ø> (ø)
kafka-v2 1.70% <ø> (ø)
memory_v2 1.70% <ø> (ø)
opensearch-1.x-v1 18.86% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 18.85% <ø> (ø)
opensearch-2.x-v2 1.69% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 95.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 27d5491 into jaegertracing:main Oct 22, 2024
49 of 52 checks passed
@yurishkuro yurishkuro deleted the config-docs branch October 22, 2024 17:58
chahatsagarmain pushed a commit to chahatsagarmain/jaeger that referenced this pull request Oct 23, 2024
Improve documentation

Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro added a commit to yurishkuro/jaeger that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code storage/elasticsearch v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants