Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternate way to install gotip #5618

Merged
merged 12 commits into from
Jun 15, 2024
+53 −9
Merged

Add alternate way to install gotip #5618

Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cc84faa
fixed gotip installation workflow
EraKin575 Jun 12, 2024
ba2faf6
Merge branch 'jaegertracing:main' into gotip
EraKin575 Jun 12, 2024
29a8f98
Merge branch 'jaegertracing:main' into gotip
EraKin575 Jun 13, 2024
b372477
fixed gotip workflow
EraKin575 Jun 13, 2024
ce819a9
Merge branch 'gotip' of https://github.com/EraKin575/jaeger into gotip
EraKin575 Jun 13, 2024
498b492
fixed gotip workflow
EraKin575 Jun 13, 2024
ae17d69
Merge branch 'main' into gotip
EraKin575 Jun 13, 2024
c7a543e
added go version step
EraKin575 Jun 13, 2024
5f88e92
Merge branch 'gotip' of https://github.com/EraKin575/jaeger into gotip
EraKin575 Jun 13, 2024
8071d01
Merge branch 'main' into gotip
EraKin575 Jun 14, 2024
b621098
Merge branch 'main' into gotip
EraKin575 Jun 15, 2024
cf91ff3
fix
yurishkuro Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions .github/actions/setup-go-tip/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Inspired by https://github.com/actions/setup-go/issues/21#issuecomment-997208686
name: 'Install Go Tip'
description: 'Install Go Tip toolchain'
runs:
using: "composite"
steps:
- name: Install Go Tip
- name: Download Go Tip
id: download-go-tip
shell: bash
run: |
set -euo pipefail
Expand All @@ -22,11 +22,12 @@ runs:
echo "Failed to download. Retrying in $wait_time seconds..."
sleep $wait_time
done
echo "download_status=${success}" >> $GITHUB_OUTPUT

if [[ "$success" == false ]]; then
echo "Failed to download Go Tip after $retries attempts"
exit 1
fi
- name: Install Go Tip
if: steps.download-go-tip.outputs.download_status == 'true'
shell: bash
run: |
echo "Downloaded bundle:"
ls -lah gotip.tar.gz
export GOROOT="$HOME/sdk/gotip"
Expand All @@ -39,3 +40,13 @@ runs:
echo "PATH=$PATH" >> $GITHUB_ENV
echo "Active Go version:"
go version

- name: Build Go Tip from source
if: steps.download-go-tip.outputs.download_status == 'false'
shell: bash
run: |
go install golang.org/dl/gotip@latest
gotip download
echo "GOROOT=$(go env GOROOT)" >> $GITHUB_ENV
echo "GOTIP_BIN=$(go env GOPATH)/bin/gotip" >> $GITHUB_ENV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this in your run https://github.com/EraKin575/test-project/actions/runs/9504391060/job/26196935810#step:7:66

Success. You may now run 'gotip'!
Run echo "Active Go version:"
Active Go version:
go version go1.22.4 linux/amd[64](https://github.com/EraKin575/test-project/actions/runs/9504391060/job/26196935810#step:7:67)

This isn't gotip. And I was expecting that, because you're not setting up env vars the same way as we do in L38-41. For example, you do GOROOT=$(go env GOROOT) - that's just default Go version, nothing to do with gotip.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Someting like this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note - we could still make it work, I suppose, but then we need to change how the tests are run, e.g. make test GO=gotip

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this?

I don't like "designing by screenshots" - you should test it out. This is why we have the final step to print go version