Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES fix aggregation errors when index is empty #535

Merged
merged 2 commits into from
Nov 16, 2017
Merged

ES fix aggregation errors when index is empty #535

merged 2 commits into from
Nov 16, 2017

Conversation

pavolloffay
Copy link
Member

Fixes #464

@ghost ghost assigned pavolloffay Nov 14, 2017
@ghost ghost added the review label Nov 14, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e571426 on pavolloffay:es-fix-empty-index into 10d660f on jaegertracing:master.

@yurishkuro
Copy link
Member

lgtm, but we should let @black-adder to review

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 133da74 on pavolloffay:es-fix-empty-index into 5db9cde on jaegertracing:master.

@yurishkuro yurishkuro merged commit 6897ca2 into jaegertracing:master Nov 16, 2017
@ghost ghost removed the review label Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-adder black-adder black-adder approved these changes

@vprithvi vprithvi Awaiting requested review from vprithvi

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees

@pavolloffay pavolloffay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavolloffay @coveralls @yurishkuro @black-adder