-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce version command and handler #517
Conversation
GIT_CLOSEST_TAG=$(shell git describe --abbrev=0 --tags) | ||
DATE=$(shell date -u +'%Y-%m-%dT%H:%M:%SZ') | ||
BUILD_INFO_IMPORT_PATH=github.com/uber/jaeger/pkg/version | ||
BUILD_INFO=-ldflags "-X $(BUILD_INFO_IMPORT_PATH).commitSHA=$(GIT_SHA) -X $(BUILD_INFO_IMPORT_PATH).latestVersion=$(GIT_CLOSEST_TAG) -X $(BUILD_INFO_IMPORT_PATH).date=$(DATE)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, had no idea this was even possible.
also could somebody with mac run it, I am not sure if date command works there too. |
Running on mac
|
how will it work on the command line, since we now have a root command and a single sub-command |
otherwise lgtm |
./cmd/collector/collector-linux help
./cmd/collector/collector-linux version -h
./cmd/collector/collector-linux version --cassandra.keyspace=foo
./cmd/collector/collector-linux version
|
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
265ddad
to
843aedf
Compare
No description provided.