Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startTimeMillis field to JSON Spans submitted to ElasticSearch, #491

Merged
merged 4 commits into from
Nov 4, 2017
Merged

Add startTimeMillis field to JSON Spans submitted to ElasticSearch, #491

merged 4 commits into from
Nov 4, 2017

Conversation

robinkb
Copy link

@robinkb robinkb commented Oct 24, 2017

and adjust mapping to match the new field.

Resolves #480

Signed-off-by: Robin Ketelbuters [email protected]

@robinkb
Copy link
Author

robinkb commented Oct 24, 2017

I used my corporate e-mail for sign-off. Do I need to adjust it?

EDIT; I did.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ea01260 on robinkb:es-timestamp into a7f203b on jaegertracing:master.

Robin Ketelbuters added 2 commits October 24, 2017 17:44
…nd adjust mapping to match the new field.

Signed-off-by: Robin Ketelbuters <[email protected]>
Signed-off-by: Robin Ketelbuters <[email protected]>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7cb1c64 on robinkb:es-timestamp into a7f203b on jaegertracing:master.

@yurishkuro
Copy link
Member

lgtm
cc @black-adder

@black-adder
Copy link
Contributor

Sorry, just getting around to this.

lgtm, could we update the readme: https://github.com/jaegertracing/jaeger/blob/master/plugin/storage/es/README.md

and let people know that we added the timestamp to ES so that you can do time range queries with kibana.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8e10067 on robinkb:es-timestamp into abaa65a on jaegertracing:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4e2a956 on robinkb:es-timestamp into 4c80d57 on jaegertracing:master.

@yurishkuro yurishkuro merged commit 677251a into jaegertracing:master Nov 4, 2017
@yurishkuro
Copy link
Member

thanks @robinkb !

@robinkb robinkb deleted the es-timestamp branch November 4, 2017 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants