-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add startTimeMillis field to JSON Spans submitted to ElasticSearch, #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinkb
requested review from
black-adder,
pavolloffay,
vprithvi and
yurishkuro
as code owners
October 24, 2017 08:27
I used my corporate e-mail for sign-off. Do I need to adjust it? EDIT; I did. |
…nd adjust mapping to match the new field. Signed-off-by: Robin Ketelbuters <[email protected]>
Signed-off-by: Robin Ketelbuters <[email protected]>
lgtm |
Sorry, just getting around to this. lgtm, could we update the readme: https://github.com/jaegertracing/jaeger/blob/master/plugin/storage/es/README.md and let people know that we added the timestamp to ES so that you can do time range queries with kibana. |
thanks @robinkb ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and adjust mapping to match the new field.
Resolves #480
Signed-off-by: Robin Ketelbuters [email protected]