Support Elasticsearch 8.x#4829
Conversation
Signed-off-by: bugslayer-332 <ayashwanth9503@gmail.com>
|
in the unit tests the mocks are unhappy about unexpected GetVersion call in the CIT, ES8 complains about You will need to change this flag for v8 |
|
this PR https://github.com/jaegertracing/jaeger/pull/4512/files had an example how to deal with the deprecated CLI flag. But I think we should not just remove the flag, we should change it for v8 to whatever the replacement is. |
So basically this whole set of flags have been deprecated since the version 7.16(https://www.elastic.co/guide/en/elasticsearch/reference/current/monitoring-settings.html). |
|
| TemplateBuilder: es.TextTemplateBuilder{}, | ||
| PrioritySpanTemplate: int64(c.Config.PrioritySpanTemplate), | ||
| PriorityServiceTemplate: int64(c.Config.PriorityServiceTemplate), | ||
| PriorityDependenciesTemplate: int64(c.Config.PriorityDependenciesTemplate), |
There was a problem hiding this comment.
please make sure PR description reflects all the changes, and explain why they are needed (especially the priority)
|
run |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4829 +/- ##
==========================================
- Coverage 96.44% 96.44% -0.01%
==========================================
Files 304 304
Lines 18049 18092 +43
==========================================
+ Hits 17407 17448 +41
- Misses 508 511 +3
+ Partials 134 133 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Please squash commits and sign |
Signed-off-by: bugslayer-332 <ayashwanth9503@gmail.com>
1a91d03 to
ba484ed
Compare
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
|
great job @pmuls99 ! 🎉 |
|
@yurishkuro when can we expect the next release? |
|
within a week - cc @albertteoh |
Which problem is this PR solving?
Description of the changes