Replace usage of OpenTracing constants with OpenTelemetry in the domain model

[afzal442]

Which problem is this PR solving?

• Part of Upgrade internal use of tracing to OpenTelemetry #3381
• This PR adds otel trace spans type to span model

Short description of the changes

• Replace OT trace with otel trace spans type i.e. ext.SpanKind.. with trace.SpanKind..

[albertteoh]

Looks pretty good to me, just a couple of nits.

[afzalbin64]

but the concern is why the unit test is still failing. sorry!

[albertteoh]

but the concern is why the unit test is still failing. sorry!

Ah, based on what I see here:

integration.go:184: 
        	Error Trace:	/home/runner/work/jaeger/jaeger/plugin/storage/integration/integration.go:184
        	Error:      	Should be true
        	Test:       	TestMemoryStorage/GetOperations
    integration.go:185: 	 Expected: [{example-operation-1 } {example-operation-3 server} {example-operation-4 client}]
    integration.go:186: 	 Actual  : [{example-operation-1 unspecified} {example-operation-3 server} {example-operation-4 client}]

EDIT: The assertion is in the integration test here

Also, my suggestion was incorrect, and should be:

assert.Equal(t, "unspecified", spanKind.String())

unless if we don't want to change the original behaviour, which means mapping "unspecified" back to "".

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (82e426c) 97.07% compared to head (79428b7) 97.06%.
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4614      +/-   ##
==========================================
- Coverage   97.07%   97.06%   -0.01%     
==========================================
  Files         301      301              
  Lines       17876    17877       +1     
==========================================
  Hits        17353    17353              
- Misses        419      420       +1     
  Partials      104      104              

Flag	Coverage Δ
unittests	97.06% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
cmd/query/app/apiv3/otlp_translator.go	100.00% <100.00%> (ø)
model/span.go	100.00% <100.00%> (ø)
plugin/storage/cassandra/spanstore/writer.go	100.00% <100.00%> (ø)
plugin/storage/integration/integration.go	75.95% <100.00%> (-0.39%)	⬇️
plugin/storage/memory/memory.go	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[albertteoh]

LGTM with a tiny nit.