Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cassandra-spanstore tracing instrumentation withOTEL #4599

Merged
merged 6 commits into from
Jul 31, 2023
Merged

Replace cassandra-spanstore tracing instrumentation withOTEL #4599

merged 6 commits into from
Jul 31, 2023

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented Jul 26, 2023 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • Replaces OT tracer with OTEL tracer to support jtracer pkg

@afzal442 afzal442 requested a review from a team as a code owner July 26, 2023 19:13
@afzal442 afzal442 marked this pull request as draft July 26, 2023 19:13
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04% ⚠️

Comparison is base (2c1bf07) 97.08% compared to head (46b5d93) 97.05%.
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4599      +/-   ##
==========================================
- Coverage   97.08%   97.05%   -0.04%     
==========================================
  Files         301      301              
  Lines       17857    17876      +19     
==========================================
+ Hits        17336    17349      +13     
- Misses        418      422       +4     
- Partials      103      105       +2
Flag Coverage Δ
unittests 97.05% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plugin/storage/cassandra/factory.go 97.11% <100.00%> (+0.02%) ⬆️
plugin/storage/cassandra/spanstore/reader.go 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afzal442 afzal442 marked this pull request as ready for review July 31, 2023 07:03
@afzal442 afzal442 changed the title [WIP] Adds OTEL tracer to cassandra spanstore component [WIP] Replace cassandra-spanstore tracing instrumentation withOTEL Jul 31, 2023
yurishkuro
yurishkuro approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yurishkuro yurishkuro changed the title [WIP] Replace cassandra-spanstore tracing instrumentation withOTEL Replace cassandra-spanstore tracing instrumentation withOTEL Jul 31, 2023
@yurishkuro yurishkuro merged commit 2881485 into jaegertracing:main Jul 31, 2023
31 checks passed
@afzalbin64 afzalbin64 deleted the replace-wid-otel-cassandra branch July 31, 2023 20:15
@afzalbin64 afzalbin64 restored the replace-wid-otel-cassandra branch August 14, 2023 07:20
@afzal442 afzal442 deleted the replace-wid-otel-cassandra branch August 14, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afzalbin64 afzalbin64 afzalbin64 left review comments

@yurishkuro yurishkuro yurishkuro approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afzal442 @yurishkuro @afzalbin64