Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keep-Alive flag for Zipkin HTTP server #4366

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

topjung3
Copy link
Contributor

@topjung3 topjung3 commented Apr 5, 2023

Which problem is this PR solving?

Short description of the changes

  • Add cli flag for change jaeger-collector's Zipkin HTTP server KeepAlive configuration.

@topjung3 topjung3 requested a review from a team as a code owner April 5, 2023 05:33
@topjung3 topjung3 requested a review from vprithvi April 5, 2023 05:33
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (499145f) 97.08% compared to head (42a28db) 97.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4366      +/-   ##
==========================================
- Coverage   97.08%   97.07%   -0.02%     
==========================================
  Files         300      300              
  Lines       17697    17701       +4     
==========================================
+ Hits        17182    17183       +1     
- Misses        414      416       +2     
- Partials      101      102       +1     
Flag Coverage Δ
unittests 97.07% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/collector/app/collector.go 88.00% <100.00%> (+0.09%) ⬆️
cmd/collector/app/flags/flags.go 100.00% <100.00%> (ø)
cmd/collector/app/server/zipkin.go 92.72% <100.00%> (+0.13%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro enabled auto-merge (squash) April 5, 2023 06:22
@yurishkuro yurishkuro merged commit 8204fa5 into jaegertracing:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow configuring KeepAlive for Zipkin collector
2 participants