Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4163 | Speed-up CI by using published UI artifacts #4314

Merged
merged 9 commits into from
Mar 19, 2023

Conversation

shubbham1215
Copy link
Contributor

Which problem is this PR solving?

Resolves #4163

Short description of the changes

Issues raised by the previous pull request at #4251

@shubbham1215 shubbham1215 requested a review from a team as a code owner March 19, 2023 14:32
@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (06c59e7) 97.08% compared to head (8f28c54) 97.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4314      +/-   ##
==========================================
- Coverage   97.08%   97.07%   -0.02%     
==========================================
  Files         300      300              
  Lines       17681    17681              
==========================================
- Hits        17166    17163       -3     
- Misses        414      417       +3     
  Partials      101      101              
Flag Coverage Δ
unittests 97.07% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shubbham1215
Copy link
Contributor Author

@yurishkuro Please review

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@yurishkuro yurishkuro merged commit 5ac3d8e into jaegertracing:main Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed-up CI by using published UI artifacts
2 participants