Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: build linux artifacts only for PR #4286

Merged

Conversation

Eileen-Yu
Copy link
Contributor

@Eileen-Yu Eileen-Yu commented Mar 9, 2023

Which problem is this PR solving?

Short description of the changes

  • scripts/build-upload-docker-images.sh: Set platforms variable dynamically based on env PLATFORMS the first argument
  • .github/workflows/ci-docker-build.yml: Add a new job for PR only and pass pr-only as the first argument

.github/workflows/ci-docker-build.yml Outdated Show resolved Hide resolved
.github/workflows/ci-docker-build.yml Outdated Show resolved Hide resolved
scripts/build-upload-docker-images.sh Outdated Show resolved Hide resolved
@Eileen-Yu Eileen-Yu force-pushed the eileen-yu/improve-docker-build branch 3 times, most recently from e6f11ce to 9af1a72 Compare March 9, 2023 19:58
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Eileen <[email protected]>
@Eileen-Yu Eileen-Yu force-pushed the eileen-yu/improve-docker-build branch from 9af1a72 to dd1fd4a Compare March 9, 2023 20:00
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c33ae5c) 97.09% compared to head (dd1fd4a) 97.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4286   +/-   ##
=======================================
  Coverage   97.09%   97.10%           
=======================================
  Files         302      302           
  Lines       17685    17685           
=======================================
+ Hits        17172    17173    +1     
+ Misses        413      412    -1     
  Partials      100      100           
Flag Coverage Δ
unittests 97.10% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro
Copy link
Member

Comparing runtime, this change is 24m -> 12m!

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@yurishkuro yurishkuro enabled auto-merge (squash) March 9, 2023 21:38
@yurishkuro yurishkuro merged commit cc264f6 into jaegertracing:main Mar 9, 2023
@yurishkuro
Copy link
Member

Thank you @Eileen-Yu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "docket images" CI/CD task to build for fewer architectures
2 participants