Refactor scripts/es-integration-test.sh #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportBase: 97.14% // Head: 97.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4161 +/- ##
==========================================
- Coverage 97.14% 97.12% -0.02%
==========================================
Files 296 296
Lines 17452 17452
==========================================
- Hits 16953 16951 -2
- Misses 402 403 +1
- Partials 97 98 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Yuri Shkuro <[email protected]>
|
@albertteoh fancy to review this too? |
yurishkuro
commented
Jan 15, 2023
| @@ -88,23 +88,25 @@ func TestBearTokenPropagation(t *testing.T) { | |||
|
|
|||
| // Run elastic search mocked server in background.. | |||
| // is not a full server, just mocked the necessary stuff for this test. | |||
| srv := &http.Server{Addr: ":9200"} | |||
| srv := &http.Server{Addr: ":19200"} | |||
There was a problem hiding this comment.
no reason to run test server on the official ES port (the integration script also changed to run query-service against this fake service)
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Feb 22, 2023
## Which problem is this PR solving? - OpenSearch integration tests very frequently fail - This change adds retries, but does not fundamentally fix anything else, except for making sure that we can get the container logs in case of a future failure ## Short description of the changes - Setup storage once before executing tests (even though token test does not require a real ES, it could be just a unit test) - Remove `-rm` from storage Docker commands so that the container is still available to do `docker logs` after the timeout - Change polling from 5s to 10s, for a total of 600sec - If storage is not reachable in 600sec then kill the container and retry two more times - Use trap to tear down storage (useful for local tests as otherwise container may remain if the tests fail) Signed-off-by: Yuri Shkuro <[email protected]>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Mar 5, 2023
## Which problem is this PR solving? - OpenSearch integration tests very frequently fail - This change adds retries, but does not fundamentally fix anything else, except for making sure that we can get the container logs in case of a future failure ## Short description of the changes - Setup storage once before executing tests (even though token test does not require a real ES, it could be just a unit test) - Remove `-rm` from storage Docker commands so that the container is still available to do `docker logs` after the timeout - Change polling from 5s to 10s, for a total of 600sec - If storage is not reachable in 600sec then kill the container and retry two more times - Use trap to tear down storage (useful for local tests as otherwise container may remain if the tests fail) Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: shubbham1215 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
-rmfrom storage Docker commands so that the container is still available to dodocker logsafter the timeout