Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: span tags of type int64 may lose precision #3958 PR No 2 #4034

Merged
merged 13 commits into from
Nov 9, 2022
Merged

[Bug]: span tags of type int64 may lose precision #3958 PR No 2 #4034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7567490
[Bug]: span tags of type int64 may lose precision #3958
shubbham1215 Nov 7, 2022
ae3f76b
Signed-off-by: Shubham Sawaiker <[email protected]>
shubbham1215 Nov 8, 2022
ca26556
Bump github.com/spf13/viper from 1.13.0 to 1.14.0 (#4027)
dependabot[bot] Nov 8, 2022
432a9ad
Bump github.com/dgraph-io/badger/v3 from 3.2103.3 to 3.2103.4 (#4026)
dependabot[bot] Nov 8, 2022
1e20b19
Bump github/codeql-action from 2.1.29 to 2.1.31 (#4025)
dependabot[bot] Nov 8, 2022
28ffca5
Bump anchore/sbom-action from 0.13.0 to 0.13.1 (#4024)
dependabot[bot] Nov 8, 2022
b1d5a1c
[Bug]: span tags of type int64 may lose precision
shubbham1215 Nov 8, 2022
d02aa0a
Merge branch 'jaegertracing:main' into main
shubbham1215 Nov 8, 2022
e20eddb
Signed-off-by: Shubham Sawaiker <[email protected]>
shubbham1215 Nov 8, 2022
c43bc5d
Merge branch 'main' of https://github.com/shubbham1215/jaeger into main
shubbham1215 Nov 8, 2022
a95117a
Signed-off-by: Shubham Sawaiker <[email protected]>
shubbham1215 Nov 8, 2022
1a845ba
Merge branch 'jaegertracing:main' into main
shubbham1215 Nov 9, 2022
bf0e4f8
Merge branch 'jaegertracing:main' into opensource
shubbham1215 Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions model/converter/json/fixtures/domain_01.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
"vType": "FLOAT64",
"vFloat64": 72.5
},
{
"key": "javascript_limit",
"vType": "INT64",
"vInt64": 9223372036854775222
},
{
"key": "blob",
"vType": "BINARY",
Expand Down
5 changes: 5 additions & 0 deletions model/converter/json/fixtures/ui_01.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@
"type": "float64",
"value": 72.5
},
{
"key": "javascript_limit",
"type": "int64",
"value": "9223372036854775222"
},
{
"key": "blob",
"type": "binary",
Expand Down
9 changes: 9 additions & 0 deletions model/converter/json/from_domain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,18 @@
package json

import (
"fmt"
"strings"

"github.com/jaegertracing/jaeger/model"
"github.com/jaegertracing/jaeger/model/json"
)

const (
jsMaxSafeInteger = int64(1)<<53 - 1
jsMinSafeInteger = -jsMaxSafeInteger
)

// FromDomain converts model.Trace into json.Trace format.
// It assumes that the domain model is valid, namely that all enums
// have valid values, so that it does not need to check for errors.
Expand Down Expand Up @@ -122,6 +128,9 @@ func (fd fromDomain) convertKeyValues(keyValues model.KeyValues) []json.KeyValue
value = kv.Bool()
case model.Int64Type:
value = kv.Int64()
if kv.Int64() > jsMaxSafeInteger || kv.Int64() < jsMinSafeInteger {
value = fmt.Sprintf("%d", value)
}
case model.Float64Type:
value = kv.Float64()
case model.BinaryType:
Expand Down