Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy expvar metrics implementation from jaeger-lib #3772

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 21, 2022

Follow-up to #3771

Copy expvar metrics implementation from jaeger-lib, mostly removing the dependency on the lib, aside from the usage with jaegr-client-go. The implementation still depends on go-kit, where the histogram part is complicated (although could be re-implemented by using VividCortex/histogram library directly).

This also upgrades go-kit to 0.12

Partially addresses #3766

@yurishkuro yurishkuro requested a review from a team as a code owner June 21, 2022 20:13
@yurishkuro yurishkuro requested a review from vprithvi June 21, 2022 20:13
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #3772 (c15f82e) into main (19e4544) will increase coverage by 0.01%.
The diff coverage is 97.67%.

@@            Coverage Diff             @@
##             main    #3772      +/-   ##
==========================================
+ Coverage   97.57%   97.59%   +0.01%     
==========================================
  Files         287      288       +1     
  Lines       16672    16765      +93     
==========================================
+ Hits        16267    16361      +94     
+ Misses        321      319       -2     
- Partials       84       85       +1     
Impacted Files Coverage Δ
internal/metrics/expvar/factory.go 95.77% <95.71%> (+95.77%) ⬆️
internal/metrics/expvar/cache.go 100.00% <100.00%> (ø)
internal/metrics/expvar/metrics.go 100.00% <100.00%> (ø)
pkg/config/tlscfg/cert_watcher.go 94.68% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19e4544...c15f82e. Read the comment docs.

@yurishkuro yurishkuro merged commit 583f1a1 into jaegertracing:main Jun 21, 2022
@yurishkuro yurishkuro deleted the add-expvar branch June 21, 2022 21:17
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant