Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dependency flag not recognized #3724

Merged
merged 2 commits into from
Jun 1, 2022
Merged

fix: dependency flag not recognized #3724

merged 2 commits into from
Jun 1, 2022

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Jun 1, 2022

Signed-off-by: Benedikt Bongartz [email protected]

Which problem is this PR solving?

Short description of the changes

  • init skip-dependencies flag.

@frzifus
fix: dependency flag not recognized
ddbadbf 
Signed-off-by: Benedikt Bongartz <[email protected]>
@frzifus frzifus requested a review from a team as a code owner June 1, 2022 09:40
@frzifus frzifus requested a review from vprithvi June 1, 2022 09:40
@codecov
Copy link

codecov bot commented Jun 1, 2022 •
edited
Loading

Codecov Report

Merging #3724 (cdea254) into main (3f3ab06) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3724   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files         271      271           
  Lines       16016    16017    +1     
=======================================
+ Hits        15609    15610    +1     
  Misses        321      321           
  Partials       86       86
Impacted Files Coverage Δ
cmd/es-rollover/app/flags.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f3ab06...cdea254. Read the comment docs.

@frzifus
Copy link
Member Author

frzifus commented Jun 1, 2022

Whats wrong here? https://github.com/jaegertracing/jaeger/runs/6686677583?check_suite_focus=true

@pavolloffay
Copy link
Member

/dco

@pavolloffay pavolloffay closed this Jun 1, 2022
@pavolloffay pavolloffay reopened this Jun 1, 2022
@yurishkuro yurishkuro enabled auto-merge (squash) June 1, 2022 13:50
@yurishkuro yurishkuro merged commit 3499c88 into jaegertracing:main Jun 1, 2022
@frzifus frzifus deleted the fix/skip_dependency_flag_not_recognized_#3723 branch June 1, 2022 14:40
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
@frzifus @yurishkuro @albertteoh
fix: dependency flag not recognized (jaegertracing#3724)
07251f6 
Signed-off-by: Benedikt Bongartz <[email protected]>

Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Albert Teoh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay pavolloffay approved these changes

@vprithvi vprithvi Awaiting requested review from vprithvi vprithvi is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skip dependencies flag is not recognized
3 participants
@frzifus @pavolloffay @yurishkuro