Refactor tenancy checking from gRPC to gRPC batch consumer #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3718 +/- ##
==========================================
- Coverage 97.47% 97.47% -0.01%
==========================================
Files 271 271
Lines 16017 16023 +6
==========================================
+ Hits 15613 15618 +5
Misses 319 319
- Partials 85 86 +1
Continue to review full report at Codecov.
|
yurishkuro
reviewed
May 31, 2022
esnible
force-pushed
the
flow-tenant-from-grpc-v4
branch
from
524e555
to
dec8a42
Compare
yurishkuro
previously approved these changes
Jun 1, 2022
Signed-off-by: Ed Snible <[email protected]>
Signed-off-by: Ed Snible <[email protected]>
esnible
force-pushed
the
flow-tenant-from-grpc-v4
branch
from
dec8a42
to
c59efc0
Compare
|
Note: I force pushed because I rebased so that it would merge. The only change is the rebase. |
yurishkuro
approved these changes
Jun 2, 2022
albertteoh
pushed a commit
to albertteoh/jaeger
that referenced
this pull request
Jul 13, 2022
…cing#3718) * Refactor tenancy checking from gRPC to gRPC batch consumer Signed-off-by: Ed Snible <[email protected]> * Pseudo-constructor to initialize batchConsumer Signed-off-by: Ed Snible <[email protected]> Signed-off-by: Albert Teoh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ed Snible [email protected]
The addresses #3688 (comment) by moving tenancy checking so that the OTLP consumer can reuse it.