Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Simplify field naming in CollectorOptions #3707

Merged
merged 2 commits into from
May 26, 2022

Conversation

yurishkuro
Copy link
Member

No description provided.

@yurishkuro yurishkuro requested a review from a team as a code owner May 26, 2022 19:56
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #3707 (54417be) into main (f2c6bda) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3707      +/-   ##
==========================================
+ Coverage   97.34%   97.36%   +0.01%     
==========================================
  Files         268      268              
  Lines       15745    15746       +1     
==========================================
+ Hits        15327    15331       +4     
+ Misses        330      328       -2     
+ Partials       88       87       -1     
Impacted Files Coverage Δ
cmd/collector/app/collector.go 76.36% <100.00%> (ø)
cmd/collector/app/flags.go 100.00% <100.00%> (ø)
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6094220...54417be. Read the comment docs.

@yurishkuro yurishkuro merged commit 1f4d1d2 into jaegertracing:main May 26, 2022
@yurishkuro yurishkuro deleted the otel052 branch May 26, 2022 20:16
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant