Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix favicon returning 500 inside container #3569

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Fix favicon returning 500 inside container #3569

merged 2 commits into from
Mar 8, 2022

Commits on Mar 7, 2022

  1. Fix favicon returning 500 inside container 

    net/http depends on mime-type to set the Content-Type for a http response, mime-type is calculated using https://pkg.go.dev/mime#TypeByExtension (https://github.com/golang/go/blob/master/src/net/http/fs.go#L235)
In alpine, there is no default installation of mime-type library hence net/http was setting application/text for favicon.ico which was leading to 500. Adding mailcap pacakge will install /etc/mime.types and fix the issue

Signed-off-by: Ashmita152 <[email protected]>
    @Ashmita152
    Ashmita152 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    973b4c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Feedbacks 

    Signed-off-by: Ashmita152 <[email protected]>
    @Ashmita152
    Ashmita152 committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    cef185b View commit details
    Browse the repository at this point in the history