Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go compiler in CI to 1.17.6 #3516

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

yurishkuro
Copy link
Member

Related to #3514

@yurishkuro yurishkuro requested a review from a team as a code owner February 4, 2022 16:14
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #3516 (081ae1f) into main (5cb41b4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3516   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         262      262           
  Lines       15337    15337           
=======================================
  Hits        14798    14798           
  Misses        456      456           
  Partials       83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cb41b4...081ae1f. Read the comment docs.

@@ -21,7 +21,7 @@ jobs:

- uses: actions/setup-go@v2
with:
go-version: ^1.17
go-version: ^1.17.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version does the 1.17 pick up? I would assume it is the latest one?

Copy link
Member Author

@yurishkuro yurishkuro Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably does, but why risk it. 1.18 is supposed to come out in Feb iiuc, so we'll switch to that and won't have the patch No frozen.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@yurishkuro yurishkuro merged commit 77ac36a into jaegertracing:main Feb 4, 2022
@yurishkuro yurishkuro deleted the go-1.17.6 branch February 4, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants