Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug image builds by installing build-base to enable GCC #3400

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Fix debug image builds by installing build-base to enable GCC #3400

merged 2 commits into from
Nov 19, 2021

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Nov 19, 2021 •
edited
Loading

@yurishkuro yurishkuro requested a review from a team as a code owner November 19, 2021 19:51
@codecov
Copy link

codecov bot commented Nov 19, 2021 •
edited
Loading

Codecov Report

Merging #3400 (a6aa332) into master (639333a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3400   +/-   ##
=======================================
  Coverage   96.47%   96.48%           
=======================================
  Files         260      260           
  Lines       15215    15215           
=======================================
+ Hits        14679    14680    +1     
+ Misses        453      452    -1     
  Partials       83       83
Impacted Files Coverage Δ
cmd/query/app/server.go 94.11% <0.00%> (-1.48%) ⬇️
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️
cmd/collector/app/server/zipkin.go 70.73% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 639333a...a6aa332. Read the comment docs.

albertteoh
albertteoh previously approved these changes Nov 19, 2021
View reviewed changes
@yurishkuro yurishkuro changed the title Go back to golang:1.17-alpine Fix debug image builds by installing build-base to enable GCC Nov 19, 2021
@yurishkuro yurishkuro merged commit 4d967d0 into jaegertracing:master Nov 19, 2021
@yurishkuro yurishkuro deleted the back-to-alpine branch November 19, 2021 22:06
rbroggi pushed a commit to rbroggi/jaeger that referenced this pull request Nov 22, 2021
@yurishkuro @rbroggi
Fix debug image builds by installing build-base to enable GCC (jaeg…
07e17e3 
…ertracing#3400)

* Go back to golang:1.17-alpine

Signed-off-by: Yuri Shkuro <[email protected]>

* Add build-base to Docker image

Signed-off-by: Yuri Shkuro <[email protected]>
@jpkrohling jpkrohling added this to the v1.29.0 milestone Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertteoh albertteoh albertteoh left review comments

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott was automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.29.0
Development

Successfully merging this pull request may close these issues.

Debug image building fails in the main branch
3 participants
@yurishkuro @albertteoh @jpkrohling