Fix args order in strings.Contains in es-rollover #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we do `strings.Contains("resource_already_exists_exception", errorMap["type"].(string))`,
we're basically doing `"resource_already_exists_exception" == errorMap["type"].(string)`.
I would assume that we intended to test whether `errorMap["type"]` contains
`"resource_already_exists_exception"` as a substring, so the reverse `strings.Contains` order
is more applicable here.
Signed-off-by: Pavol Loffay <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3324 +/- ##
==========================================
+ Coverage 95.96% 96.00% +0.03%
==========================================
Files 259 259
Lines 15434 15434
==========================================
+ Hits 14811 14817 +6
+ Misses 528 523 -5
+ Partials 95 94 -1
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Oct 14, 2021
albertteoh
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3319
If we do
strings.Contains("resource_already_exists_exception", errorMap["type"].(string)),we're basically doing
"resource_already_exists_exception" == errorMap["type"].(string).I would assume that we intended to test whether
errorMap["type"]contains"resource_already_exists_exception"as a substring, so the reversestrings.Containsorderis more applicable here.
Signed-off-by: Pavol Loffay [email protected]
Which problem is this PR solving?
Short description of the changes