Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing otel configuration in docker compose #3286

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

Ashmita152
Copy link
Contributor

Signed-off-by: Ashmita152 [email protected]

Which problem is this PR solving?

  • Fixing otel configuration in docker-compose

Short description of the changes

@Ashmita152 Ashmita152 requested a review from a team as a code owner September 27, 2021 12:51
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #3286 (807fb4e) into master (550c649) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3286      +/-   ##
==========================================
- Coverage   95.86%   95.81%   -0.05%     
==========================================
  Files         259      259              
  Lines       15413    15413              
==========================================
- Hits        14775    14768       -7     
- Misses        549      554       +5     
- Partials       89       91       +2     
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 94.01% <0.00%> (-4.80%) ⬇️
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️
cmd/query/app/server.go 95.58% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 550c649...807fb4e. Read the comment docs.

Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version of the collector are we using?

Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@albertteoh albertteoh enabled auto-merge (squash) September 27, 2021 13:03
@albertteoh albertteoh merged commit 410bfcc into jaegertracing:master Sep 27, 2021
@albertteoh
Copy link
Contributor

albertteoh commented Sep 27, 2021

What version of the collector are we using?

In what context? Did you mean which otel collector (or jaeger collector) version is used in the docker-compose? If so, it's the "latest" image tags.

@joe-elliott joe-elliott added this to the v1.27.0 milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants