Added ability to pass config file to grpc plugin in integration tests #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If PLUGIN_CONFIG_PATH env var is set, its value is passed to --grpc-storage-plugin.configuration-file flag. Signed-off-by: Yury Frolov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3253 +/- ##
==========================================
- Coverage 95.82% 95.80% -0.02%
==========================================
Files 259 259
Lines 15398 15398
==========================================
- Hits 14755 14752 -3
- Misses 553 555 +2
- Partials 90 91 +1
Continue to review full report at Codecov.
|
|
Please revert changes for the jaeger-ui |
Signed-off-by: Yury Frolov <[email protected]>
pavolloffay
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #3221
Short description of the changes