Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go v1.17 #3220

Merged
merged 5 commits into from
Aug 20, 2021
Merged

Upgrade to Go v1.17 #3220

merged 5 commits into from
Aug 20, 2021

Conversation

Ashmita152
Copy link
Contributor

Signed-off-by: Ashmita Bohara [email protected]

Which problem is this PR solving?

Upgrade to Go v1.17

Short description of the changes

Ran go mod tidy too

Signed-off-by: Ashmita Bohara <[email protected]>
@Ashmita152 Ashmita152 requested a review from a team as a code owner August 19, 2021 11:15
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #3220 (4e37d4f) into master (569da08) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3220   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files         242      242           
  Lines       14789    14789           
=======================================
+ Hits        14196    14197    +1     
+ Misses        514      513    -1     
  Partials       79       79           
Impacted Files Coverage Δ
cmd/agent/app/servers/thriftudp/socket_buffer.go 50.00% <ø> (ø)
pkg/config/tlscfg/certpool_unix.go 100.00% <ø> (ø)
cmd/collector/app/server/zipkin.go 68.29% <0.00%> (-2.44%) ⬇️
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.20%) ⬇️
plugin/storage/integration/integration.go 78.88% <0.00%> (-0.40%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.21% <0.00%> (+0.70%) ⬆️
pkg/config/tlscfg/cert_watcher.go 94.73% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 569da08...4e37d4f. Read the comment docs.

@Ashmita152
Copy link
Contributor Author

golang/go#47810

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version is also present in docker files.

Signed-off-by: Ashmita Bohara <[email protected]>
@Ashmita152
Copy link
Contributor Author

I think this handles all usages of golang 1.16 to 1.17.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 13ccfa5 into jaegertracing:master Aug 20, 2021
@jpkrohling jpkrohling added this to the v1.26.0 milestone Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants