Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert MetricsQueryService to interface #3089

Merged

Conversation

albertteoh
Copy link
Contributor

Signed-off-by: albertteoh [email protected]

Which problem is this PR solving?

Short description of the changes

  • Follow up to suggestion made in this comment.
  • Removes much of the unnecessary duplicated proxy code from MetricsQueryService by making it an interface, that embeds the metricsstore.Reader interface.

albertteoh added 2 commits June 13, 2021 15:26
@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #3089 (c865d7d) into master (013efad) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3089      +/-   ##
==========================================
- Coverage   95.87%   95.83%   -0.04%     
==========================================
  Files         236      235       -1     
  Lines       10073    10067       -6     
==========================================
- Hits         9657     9648       -9     
- Misses        346      347       +1     
- Partials       70       72       +2     
Impacted Files Coverage Δ
cmd/query/app/server.go 95.62% <ø> (-1.46%) ⬇️
cmd/query/app/static_handler.go 95.16% <0.00%> (-1.62%) ⬇️
plugin/storage/integration/integration.go 77.34% <0.00%> (-0.56%) ⬇️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013efad...c865d7d. Read the comment docs.

@albertteoh albertteoh marked this pull request as ready for review June 13, 2021 06:19
@albertteoh albertteoh requested a review from a team as a code owner June 13, 2021 06:19
@yurishkuro yurishkuro merged commit c9d6957 into jaegertracing:master Jun 13, 2021
@albertteoh albertteoh deleted the 2954-metricsqueryservice-interface branch June 14, 2021 00:09
@jpkrohling jpkrohling added this to the Release 1.24.0 milestone Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants